-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extract code into external files #1949
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carols10cents
added
the
blocked upstream
Blocked on a change that needs to happen in a different repo first
label
May 7, 2019
carols10cents
force-pushed
the
extract-files
branch
5 times, most recently
from
August 30, 2019 02:29
1e1cfa5
to
233d16e
Compare
carols10cents
force-pushed
the
extract-files
branch
from
September 11, 2019 01:22
233d16e
to
2c61364
Compare
Triage: mdbook PR is still open. |
carols10cents
force-pushed
the
extract-files
branch
from
September 25, 2019 15:40
2c61364
to
2ccaaa5
Compare
carols10cents
force-pushed
the
extract-files
branch
from
September 29, 2019 01:36
bf92eb3
to
f3ad37d
Compare
carols10cents
force-pushed
the
extract-files
branch
from
October 6, 2019 18:46
18e325c
to
7fb88da
Compare
This makes the line numbers in error messages match what the reader will see.
Now with correct line numbers!
Anything except closing parens, really
Closing in favor of a new PR I've organized differently. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1889.
Can't be merged until rust-lang/mdBook#1003 is merged and released and the released version of mdbook is available in rust-lang/rust, and the following are completed:
TODO
rg rustdoc_include.*\\.rs:[0-9] src/*.md
fn main() {}
s insrc/lib.rs
sand produces a github "release" artifact that's just the listings to download
In future PRs (this is just for my own brain parking lot to keep me on task)
and fixa bug where include doesn't work within blockquotes: Include directives don't like being within blockquotes mdBook#1127