Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cargo intercepts --version flags in third party subcommands #2286

Closed
sfackler opened this issue Jan 16, 2016 · 2 comments
Closed

Cargo intercepts --version flags in third party subcommands #2286

sfackler opened this issue Jan 16, 2016 · 2 comments
Labels
E-easy Experience: Easy

Comments

@sfackler
Copy link
Member

If a third party subcommand registers a --version flag and uses the execute_main_without_stdin infrastructure, the cargo crate will intercept --version and print its own version, rather than passing it through to to the subcommand main.
sfackler added a commit to sfackler/cargo-tree that referenced this issue Jan 17, 2016
@sfackler
Add a version flag
e0999ca 
Doesn't actually do anything due to rust-lang/cargo#2286
@alexcrichton
Copy link
Member

Should be a relatively easy fix

@alexcrichton alexcrichton added the E-easy Experience: Easy label Jan 17, 2016
antonlarin added a commit to antonlarin/cargo that referenced this issue Jan 30, 2016
@antonlarin
Fix interception of subcommand --version flag
3fb5054 
Addresses rust-lang#2286: when subcommand used execute_main_without_stdin and
provided --version flag, cargo intercepted it and printed it's own
version.
@antonlarin antonlarin mentioned this issue Jan 30, 2016
Merged
bors added a commit that referenced this issue Feb 1, 2016
@bors
Auto merge of #2336 - antonlarin:version-flag-interception-fix, r=ale…
289411b 
…xcrichton

Addresses #2286: when subcommand used `execute_main_without_stdin` and provided `--version` flag, cargo intercepted it and printed it's own version.
@antonlarin
Copy link
Contributor

The issue should be closed since it was fixed in #2336.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
E-easy Experience: Easy
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexcrichton @antonlarin @sfackler