Feature Request: A way to deprecate features #7130
Labels
A-features
Area: features — conditional compilation
C-feature-request
Category: proposal for a feature. Before PR, ping rust-lang/cargo if this is not `Feature accepted`
S-needs-rfc
Status: Needs an RFC to make progress.
Comments
llogiq
added
the
C-feature-request
|
I'm not sure if |
Enselic
pushed a commit
to Enselic/syntect
that referenced
this issue
Dec 28, 2021
When the `-rs` versions of dump creation and loading were introduced in syntect, `flate2` defaulted to a C implementation and made the Rust backend optional. Since two years, the Rust backend has been the default backend. See rust-lang/flate2-rs@c479d064e2. So we can stop using the `-rs` versions since enabling them makes no difference. Note that there is no mechanism yet that we can use to mark features as deprecated. See rust-lang/cargo#7130
This was referenced Jul 19, 2022
|
This would be covered as part of rust-lang/rfcs#3416 if accepted |
|
@tgross35 rust-lang/rfcs#3416 was merged in. What are the next steps to allow feature deprecation? |
|
rust-lang/rfcs#3486 has not yet been merged, which is the RFC for deprecation. There is still a lot more deciding to be done there and I haven't gotten around to it; feel free to provide feedback there, or better yet propose changes via the GH API so they can be applied. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I have a crate that has a feature that is no longer needed. For now, I keep the feature, but it does nothing. I will at some point remove the feature, but I'd like to be able to issue a warning before removing it.
An easy an approachable way would be to nominate a special "deprecated" feature that is always available, so we could write
my_feature = "deprecated"in ourCargo.toml. However, this would need a survey of crates to see if any already define such a feature.Another option is to stabilize the
proc_macro_diagnosticsfeature in rustc, that would allow us to issue a compile-time warning if the feature is selected, albeit with more ceremony.The text was updated successfully, but these errors were encountered: