-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clap requirement from 2.34.0 to 3.0.1 #10253
Conversation
Updates the requirements on [clap](https://github.com/clap-rs/clap) to permit the latest version. - [Release notes](https://github.com/clap-rs/clap/releases) - [Changelog](https://github.com/clap-rs/clap/blob/master/CHANGELOG.md) - [Commits](clap-rs/clap@clap_generate-v3.0.0-rc.0...clap_complete-v3.0.1) --- updated-dependencies: - dependency-name: clap dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com>
(rust-highfive has picked a reviewer for you, use r? to override) |
Are there any thoughts on whether to port immediately or wait? I'd be willing to port cargo, just double checking that it is wanted at this time. |
I am one vote among several, but I would be happy to have you do the update! |
I think it'd be good to upgrade yeah, but Cargo's pretty big and this is probably a big update so we'll likely want to pay special attention to any changes in |
Yes, I am especially concerned about the unenumerated parser changes that happened before I took over (clap-rs/clap#3249 being an example that doesn't impact cargo) |
Superseded by #10259. |
As an update, I've now got this down to a debug assert during |
Updates the requirements on clap to permit the latest version.
Release notes
Sourced from clap's releases.
Changelog
Sourced from clap's changelog.
... (truncated)
Commits
d392b88
chore: Release1a19d48
docs: Update changelog3782d8e
Merge pull request #3247 from epage/len5c829ff
Merge pull request #3246 from epage/warne580683
fix: Don't panic when getting number of values6b9ae54
fix(derive): Don't enit warningsb0cb205
docs(derive): Include name magic attribute06f24b1
Merge pull request #3243 from intgr/fix-clap_complete-documentation-importsf10c5d1
docs(complete): Fix imports in documentation879219a
Merge pull request #3240 from epage/heckDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)