Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: doc comments for all registry kinds #12247

Merged
merged 7 commits into from
Jun 9, 2023
Merged

Conversation

weihanglo
Copy link
Member

What does this PR try to resolve?

Doc comments for all registry kinds.

How should we test and review this PR?

cargo doc --document-private-items --no-deps --open

Then proofread it!

Additional information

I think I'll take a break from refining docs.

@rustbot
Copy link
Collaborator

rustbot commented Jun 9, 2023

r? @ehuss

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added A-configuration Area: cargo config files and env vars A-local-registry-source Area: local registry sources (vendoring) A-registries Area: registries A-sparse-registry Area: http sparse registries S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2023
src/cargo/sources/registry/remote.rs Outdated Show resolved Hide resolved
src/cargo/sources/registry/remote.rs Outdated Show resolved Hide resolved
src/cargo/sources/registry/remote.rs Outdated Show resolved Hide resolved
src/cargo/sources/registry/remote.rs Outdated Show resolved Hide resolved
@epage
Copy link
Contributor

epage commented Jun 9, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Jun 9, 2023

📌 Commit 2c48599 has been approved by epage

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2023
@bors
Copy link
Contributor

bors commented Jun 9, 2023

⌛ Testing commit 2c48599 with merge b6744b9...

bors added a commit that referenced this pull request Jun 9, 2023
docs: doc comments for all registry kinds
@bors
Copy link
Contributor

bors commented Jun 9, 2023

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 9, 2023
@weihanglo
Copy link
Member Author

Timeout with no reason.

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 9, 2023
@bors
Copy link
Contributor

bors commented Jun 9, 2023

⌛ Testing commit 2c48599 with merge 49b6d9e...

@bors
Copy link
Contributor

bors commented Jun 9, 2023

☀️ Test successful - checks-actions
Approved by: epage
Pushing 49b6d9e to master...

@bors bors merged commit 49b6d9e into rust-lang:master Jun 9, 2023
@weihanglo weihanglo deleted the source-doc branch June 9, 2023 18:14
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 10, 2023
Update cargo

12 commits in b0fa79679e717cd077b7fc0fa4166f47107f1ba9..49b6d9e179a91cf7645142541c9563443f64bf2b
2023-06-03 14:19:48 +0000 to 2023-06-09 17:21:19 +0000
- docs: doc comments for all registry kinds (rust-lang/cargo#12247)
- chore: Migrate print-ban from test to clippy (rust-lang/cargo#12246)
- fix: fetch nested git submodules (rust-lang/cargo#12244)
- refactor: registry source cleanup (rust-lang/cargo#12240)
- test: loose overly matches for git cli output (rust-lang/cargo#12241)
- fix: disable multiplexing on macOS for some versions of curl (rust-lang/cargo#12234)
- docs: doc comments for registry source and index (rust-lang/cargo#12239)
- doc: point to nightly cargo doc (rust-lang/cargo#12237)
- Upgrade to `gix` v0.45 for multi-round pack negotiations. (rust-lang/cargo#12236)
- refactor: git source cleanup (rust-lang/cargo#12197)
- Add message on reusing previous temporary path on failed cargo installs (rust-lang/cargo#12231)
- doc: the first line should be a simple sentence instead of a heading (rust-lang/cargo#12228)

r? `@ghost`
@ehuss ehuss added this to the 1.72.0 milestone Jun 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-configuration Area: cargo config files and env vars A-local-registry-source Area: local registry sources (vendoring) A-registries Area: registries A-sparse-registry Area: http sparse registries S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants