-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[beta-1.76.0] chore: tracing be compat with rustc_log #13242
Merged
bors
merged 1 commit into
rust-lang:rust-1.76.0
from
weihanglo:tracing-core-beta-backport
Jan 2, 2024
Merged
[beta-1.76.0] chore: tracing be compat with rustc_log #13242
bors
merged 1 commit into
rust-lang:rust-1.76.0
from
weihanglo:tracing-core-beta-backport
Jan 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The current version of rustfix cannot be used in rust-lang/rust due to the dependency on `tracing`. `tracing-core` is currently locked to 0.1.30, which is too old for the version in the cargo repo (it looks like they are trying to avoid a known deadlock). See: https://rust-lang.zulipchat.com/#narrow/stream/246057-t-cargo/topic/rustfix.20is.20incompatible.20with.20rust-lang.2Frust
r? @ehuss (rustbot has picked a reviewer for you, use r? to override) |
|
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Jan 2, 2024
@bors r+ |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Jan 2, 2024
☀️ Test successful - checks-actions |
1 similar comment
☀️ Test successful - checks-actions |
👀 Test was successful, but fast-forwarding failed: 422 Changes must be made through a pull request. |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 6, 2024
…nglo [beta-1.76] Update cargo 1 commits in 1a2666ddd14cf0a255d4ddb61c63531c259a7b39..ddec30889aff0c38118bcbeb59597d0bd85eddcd 2023-12-17 17:53:53 +0000 to 2024-01-02 23:23:28 +0000 - [beta-1.76.0] chore: tracing be compat with rustc_log (rust-lang/cargo#13242) r? ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Beta backports:
In order to make CI pass, the following PRs are also cherry-picked: