-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update pulldown-cmark to 0.10.0 #13517
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @epage (or someone else) some time within the next two weeks. Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
The tests in mdman
is failing.
click to see the error
thread 'tables' panicked at crates/mdman/tests/compare.rs:25:9:
error: test failed, to rerun pass `-p mdman --test compare`
---- expected: tests/compare/expected/tables.1
++++ actual: In-memory
1 1 | '\" t
2 2 | .TH "TABLES" "1"
3 3 | .nh
4 4 | .ad l
5 5 | .ss \n[.ss] 0
6 6 | .SH "DESCRIPTION"
7 7 | Testing tables.
8 -
9 - .TS
10 - allbox tab(:);
11 - lt.
12 - T{
13 - Single col
14 - T}
15 - T{
16 - Hi! :)
17 - T}
18 - .TE
19 - .sp
8 + .SH "| Single col |"
9 + | Hi! :) |
20 10 |
21 11 | .TS
22 12 | allbox tab(:);
23 13 | lt lt lt.
24 14 | T{
⋮
89 79 | T}:T{
90 80 | Extra long text 123456789012 with mixed widths.
91 81 | T}
92 82 | .TE
93 83 | .sp
94 -
95 - .TS
96 - allbox tab(:);
97 - lt.
98 - T{
99 - Link check
100 - T}
101 - T{
102 - \fIfoo\fR <https://example.com/>
103 - T}
104 - T{
105 - <https://example.com/>
106 - T}
107 - .TE
108 - .sp
84 + .SH "| Link check |"
85 + | \fIfoo\fR <https://example.com/> |
86 + | <https://example.com/> |
Update with SNAPSHOTS=overwrite
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
Please run SNAPSHOTS=overwrite cargo test -p mdman --test compare
to generate new UI snapshots.
Single-column table is not rendered as before. I believe it is the test cases are ill-formatted and we need to update them: diff --git a/crates/mdman/tests/compare/tables.md b/crates/mdman/tests/compare/tables.md
index 831132c44ec..fb4acf63656 100644
--- a/crates/mdman/tests/compare/tables.md
+++ b/crates/mdman/tests/compare/tables.md
@@ -5,7 +5,7 @@
Testing tables.
| Single col |
---------------
+|------------|
| Hi! :) |
@@ -27,7 +27,7 @@ Extra long text 123456789012 with mixed widths. | Extra long text 123456789012 w
| Link check |
---------------
+|------------|
| [foo] |
| <https://example.com/> | As this example shows, GitHub-flavored table supports single column. The ill-formatted test case doesn't work on GitHub: | Link check || [foo] | |
@rustbot author |
f03e292
to
19a0606
Compare
19a0606
to
604d2e4
Compare
@rustbot ready |
Thanks! @bors r+ |
☀️ Test successful - checks-actions |
Update cargo 11 commits in f772ec0224d3755ce52ac5128a80319fb2eb45d0..c3c417b85e01a1de1633317fa55e4f1a31e346d4 2024-03-01 22:57:35 +0000 to 2024-03-06 01:16:08 +0000 - fix(rustdoc-map): dedup `--extern-html-too-url` for same unit (rust-lang/cargo#13544) - test: Add test for packaging a public dependency (rust-lang/cargo#13536) - doc: Edits for git/path dependency sections (rust-lang/cargo#13341) - feat(cli): Allow logging to chrome traces (rust-lang/cargo#13399) - fix(log): Trace parameters to align with profile (rust-lang/cargo#13538) - fix(toml): Don't warn on unset Edition if only 2015 is compatible (rust-lang/cargo#13533) - fix(cli): Trace core cargo operations (rust-lang/cargo#13532) - chore: update pulldown-cmark to 0.10.0 (rust-lang/cargo#13517) - feat(add): Fallback to `rustc -v` when no MSRV is set (rust-lang/cargo#13516) - chore(ci): Ensure lockfile is respected during MSRV testing (rust-lang/cargo#13523) - feat: Use consistent colors when testing (rust-lang/cargo#13520) r? ghost
Update cargo 14 commits in f772ec0224d3755ce52ac5128a80319fb2eb45d0..a4c63fe5388beaa09e5f91196c86addab0a03580 2024-03-01 22:57:35 +0000 to 2024-03-06 22:15:17 +0000 - fix(cli): Skip tracing-chrome for platforms without 64bit atomics (rust-lang/cargo#13551) - chore: downgrade to openssl v1.1.1 (again) (rust-lang/cargo#13550) - fix(cli): Add traces to clarify where time is going (rust-lang/cargo#13545) - fix(rustdoc-map): dedup `--extern-html-too-url` for same unit (rust-lang/cargo#13544) - test: Add test for packaging a public dependency (rust-lang/cargo#13536) - doc: Edits for git/path dependency sections (rust-lang/cargo#13341) - feat(cli): Allow logging to chrome traces (rust-lang/cargo#13399) - fix(log): Trace parameters to align with profile (rust-lang/cargo#13538) - fix(toml): Don't warn on unset Edition if only 2015 is compatible (rust-lang/cargo#13533) - fix(cli): Trace core cargo operations (rust-lang/cargo#13532) - chore: update pulldown-cmark to 0.10.0 (rust-lang/cargo#13517) - feat(add): Fallback to `rustc -v` when no MSRV is set (rust-lang/cargo#13516) - chore(ci): Ensure lockfile is respected during MSRV testing (rust-lang/cargo#13523) - feat: Use consistent colors when testing (rust-lang/cargo#13520)
Update cargo 14 commits in f772ec0224d3755ce52ac5128a80319fb2eb45d0..a4c63fe5388beaa09e5f91196c86addab0a03580 2024-03-01 22:57:35 +0000 to 2024-03-06 22:15:17 +0000 - fix(cli): Skip tracing-chrome for platforms without 64bit atomics (rust-lang/cargo#13551) - chore: downgrade to openssl v1.1.1 (again) (rust-lang/cargo#13550) - fix(cli): Add traces to clarify where time is going (rust-lang/cargo#13545) - fix(rustdoc-map): dedup `--extern-html-too-url` for same unit (rust-lang/cargo#13544) - test: Add test for packaging a public dependency (rust-lang/cargo#13536) - doc: Edits for git/path dependency sections (rust-lang/cargo#13341) - feat(cli): Allow logging to chrome traces (rust-lang/cargo#13399) - fix(log): Trace parameters to align with profile (rust-lang/cargo#13538) - fix(toml): Don't warn on unset Edition if only 2015 is compatible (rust-lang/cargo#13533) - fix(cli): Trace core cargo operations (rust-lang/cargo#13532) - chore: update pulldown-cmark to 0.10.0 (rust-lang/cargo#13517) - feat(add): Fallback to `rustc -v` when no MSRV is set (rust-lang/cargo#13516) - chore(ci): Ensure lockfile is respected during MSRV testing (rust-lang/cargo#13523) - feat: Use consistent colors when testing (rust-lang/cargo#13520)
Update cargo 14 commits in f772ec0224d3755ce52ac5128a80319fb2eb45d0..a4c63fe5388beaa09e5f91196c86addab0a03580 2024-03-01 22:57:35 +0000 to 2024-03-06 22:15:17 +0000 - fix(cli): Skip tracing-chrome for platforms without 64bit atomics (rust-lang/cargo#13551) - chore: downgrade to openssl v1.1.1 (again) (rust-lang/cargo#13550) - fix(cli): Add traces to clarify where time is going (rust-lang/cargo#13545) - fix(rustdoc-map): dedup `--extern-html-too-url` for same unit (rust-lang/cargo#13544) - test: Add test for packaging a public dependency (rust-lang/cargo#13536) - doc: Edits for git/path dependency sections (rust-lang/cargo#13341) - feat(cli): Allow logging to chrome traces (rust-lang/cargo#13399) - fix(log): Trace parameters to align with profile (rust-lang/cargo#13538) - fix(toml): Don't warn on unset Edition if only 2015 is compatible (rust-lang/cargo#13533) - fix(cli): Trace core cargo operations (rust-lang/cargo#13532) - chore: update pulldown-cmark to 0.10.0 (rust-lang/cargo#13517) - feat(add): Fallback to `rustc -v` when no MSRV is set (rust-lang/cargo#13516) - chore(ci): Ensure lockfile is respected during MSRV testing (rust-lang/cargo#13523) - feat: Use consistent colors when testing (rust-lang/cargo#13520)
What does this PR try to resolve?
Update a dependency and address its breaking changes.
pulldown-cmark: 0.9.3 -> 0.10.0
Fixes: #13509
How should we test and review this PR?
The
.md
and.1
docs are updated as part of this commit, you can see there that nothing changes except for removal of some trailing whitespace.