Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump to 0.34.0 #6399

Merged
merged 1 commit into from
Dec 8, 2018
Merged

Bump to 0.34.0 #6399

merged 1 commit into from
Dec 8, 2018

Conversation

alexcrichton
Copy link
Member

No description provided.

@alexcrichton
Copy link
Member Author

@bors: r+

@bors
Copy link
Collaborator

bors commented Dec 8, 2018

📌 Commit 1b886f7 has been approved by alexcrichton

@bors
Copy link
Collaborator

bors commented Dec 8, 2018

⌛ Testing commit 1b886f7 with merge 316182ebced80bfa0033a91f0202b28c4c730a8c...

@bors
Copy link
Collaborator

bors commented Dec 8, 2018

💔 Test failed - status-appveyor

@dwijnand
Copy link
Member

dwijnand commented Dec 8, 2018

Oh dear did I break it? I might not get until tomorrow a chance to look into it on a laptop.

@alexcrichton
Copy link
Member Author

Ah no worries I'll take care of it in #6400

@bors: retry

@ehuss
Copy link
Contributor

ehuss commented Dec 8, 2018

For reference, it looks like this was caused by rust-lang/rust#56392. Before that PR, the entries like use cargo; did not issue an unused warning.

@bors
Copy link
Collaborator

bors commented Dec 8, 2018

⌛ Testing commit 1b886f7 with merge c4b5a63...

bors added a commit that referenced this pull request Dec 8, 2018
@bors
Copy link
Collaborator

bors commented Dec 8, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing c4b5a63 to master...

@bors bors merged commit 1b886f7 into rust-lang:master Dec 8, 2018
@ehuss ehuss added this to the 1.33.0 milestone Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants