-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Document cargo limitation w/ workspaces & configs #9674
Conversation
This behavior is described in this bug: rust-lang#2930 I think we should document limitations of the tool which exist at present if they do not bind our hands in the future. If this bug is fixed, this note should be removed.
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @ehuss (or someone else) soon. Please see the contribution instructions for more information. |
This change was made from the github editor, and not tested locally. |
Thanks for this! I think this is probably good to clarify, but I think it's ok to happen outside of a quoted block (e.g. no |
Thanks for the advice, I've moved it outside a quoted block :) |
Tying two separate thread together: another contributor says that it is currently documented on that page, ("It looks for configuration files in the current directory and all parent directories"), but I think we should document this caveat explicitly, which is why I opened this PR. |
@bors: r+ Ok, thanks! |
📌 Commit d054652 has been approved by |
☀️ Test successful - checks-actions |
Update cargo 6 commits in 66a6737a0c9f3a974af2dd032a65d3e409c77aac..27277d966b3cfa454d6dea7f724cb961c036251c 2021-07-14 20:54:28 +0000 to 2021-07-16 00:50:39 +0000 - Flag another curl error as possibly spurious (rust-lang/cargo#9695) - Add `d` as an alias for `doc` (rust-lang/cargo#9680) - `cargo fix --edition`: extend warning when on latest edition (rust-lang/cargo#9694) - Update env_logger requirement from 0.8.1 to 0.9.0 (rust-lang/cargo#9688) - Document cargo limitation w/ workspaces & configs (rust-lang/cargo#9674) - Change some warnings to errors (rust-lang/cargo#9689)
This behavior is described in this bug:
#2930
I think we should document limitations of the tool which exist at present if they do not bind our hands in the future.
If this bug is fixed, this note should be removed.