Remove -fembed-bitcode flag #812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
the only other case that's potentially ambiguous here is using LTO, where you might want the bitcode for that. How is this supposed to be handled by this? because also in the bitcode case this could produce only bitcode files and no object files instead |
|
I'm less sure about that now actually, I'm not 100% sure how to tell if the embedded bitcode is being used in the case of LTO builds but with a quick test generating a |
|
I don't believe we need to worry about cross-lang LTO, you pretty much have to do a bunch of special stuff to set that up anyway. I think this is correct, but ideally we'd detect the xcode version and do it based on that. I have a patch that does that somewhere, but need to dig it out (I won't have time in the next couple weeks, maybe after) |
|
I don't think we need to detect the Xcode version for this because Apple no longer accepts App Store submissions with anything other than Xcode 14.1+ so it's no longer possible to submit apps that include bitcode at all since Xcode 14.1 doesn't support it. Outside of the App store there shouldn't be any reason for folks to use bitcode |
|
That seems reasonable. I'll merge this after the current release (which is quite large), I'm concerned it may have a large degree of fallout (if there's a mistake here), and would rather that not be confusable with all the other changes that are going to go into 1.80. |
|
Sounds good, thanks! Feel free to cc me on any issues that arise |
|
This conflicts but is worth doing. Mind rebasing? |
keith
force-pushed
the
ks/remove-fembed-bitcode-flag
branch
from
61976c9
to
fe35dba
Compare
|
rebased! |
|
Ugh, sorry -- happened to merge changes before getting to this that broke it again. Can you rebase again? |
Apple has recently stopped accepting apps built with any Xcode version below 14.1, and rejects apps built with bitcode starting with Xcode 14.
keith
force-pushed
the
ks/remove-fembed-bitcode-flag
branch
from
fe35dba
to
91e514a
Compare
|
Done! |
thomcc
approved these changes
Sep 23, 2023
|
Hmmm... I'll merge this now, and look into the (certainly unrelated) CI bustage tomorrow... |
|
Thanks! |
Closed
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Nov 19, 2023
…orse, r=davidtwco Remove legacy bitcode defaults from all Apple specs Xcode 14 [deprecated bitcode with warnings](https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes#Deprecations) and now [Xcode 15 has dropped it completely](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Deprecations). `rustc` should follow what the platform tooling is doing as well since it just increases binary sizes for no gain at this point. `cc` made a [similar change last month](rust-lang/cc-rs#812). Two things show this should have minimal impact: - Apple has stopped accepting apps built with versions of Xcode (<14) that generate bitcode - The app store has been stripping bitcode off IPA releases for over 2 years now. I didn't nuke all the bitcode changes added in rust-lang#71970 since maybe another target in the future could need mandatory bitcode embedding. Staticlibs built for iOS still link correctly with XCode 15 against a test app when using a compiler built from this branch. cc `@thomcc` `@keith`
bors
added a commit
to rust-lang/miri
that referenced
this pull request
Nov 21, 2023
…avidtwco Remove legacy bitcode defaults from all Apple specs Xcode 14 [deprecated bitcode with warnings](https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes#Deprecations) and now [Xcode 15 has dropped it completely](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Deprecations). `rustc` should follow what the platform tooling is doing as well since it just increases binary sizes for no gain at this point. `cc` made a [similar change last month](rust-lang/cc-rs#812). Two things show this should have minimal impact: - Apple has stopped accepting apps built with versions of Xcode (<14) that generate bitcode - The app store has been stripping bitcode off IPA releases for over 2 years now. I didn't nuke all the bitcode changes added in rust-lang/rust#71970 since maybe another target in the future could need mandatory bitcode embedding. Staticlibs built for iOS still link correctly with XCode 15 against a test app when using a compiler built from this branch. cc `@thomcc` `@keith`
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Apr 7, 2024
…avidtwco Remove legacy bitcode defaults from all Apple specs Xcode 14 [deprecated bitcode with warnings](https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes#Deprecations) and now [Xcode 15 has dropped it completely](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Deprecations). `rustc` should follow what the platform tooling is doing as well since it just increases binary sizes for no gain at this point. `cc` made a [similar change last month](rust-lang/cc-rs#812). Two things show this should have minimal impact: - Apple has stopped accepting apps built with versions of Xcode (<14) that generate bitcode - The app store has been stripping bitcode off IPA releases for over 2 years now. I didn't nuke all the bitcode changes added in rust-lang/rust#71970 since maybe another target in the future could need mandatory bitcode embedding. Staticlibs built for iOS still link correctly with XCode 15 against a test app when using a compiler built from this branch. cc `@thomcc` `@keith`
RalfJung
pushed a commit
to RalfJung/rust-analyzer
that referenced
this pull request
Apr 27, 2024
…avidtwco Remove legacy bitcode defaults from all Apple specs Xcode 14 [deprecated bitcode with warnings](https://developer.apple.com/documentation/xcode-release-notes/xcode-14-release-notes#Deprecations) and now [Xcode 15 has dropped it completely](https://developer.apple.com/documentation/xcode-release-notes/xcode-15-release-notes#Deprecations). `rustc` should follow what the platform tooling is doing as well since it just increases binary sizes for no gain at this point. `cc` made a [similar change last month](rust-lang/cc-rs#812). Two things show this should have minimal impact: - Apple has stopped accepting apps built with versions of Xcode (<14) that generate bitcode - The app store has been stripping bitcode off IPA releases for over 2 years now. I didn't nuke all the bitcode changes added in rust-lang/rust#71970 since maybe another target in the future could need mandatory bitcode embedding. Staticlibs built for iOS still link correctly with XCode 15 against a test app when using a compiler built from this branch. cc `@thomcc` `@keith`
bors
pushed a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2024
This is a partial revert of 6d819a4 because rust-lang/cc-rs#812 removed this flag entirely, meaning we shouldn't have to pass this manually anymore
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 20, 2024
…itcode-usage-now-that-it-s-deprecated, r=clubby789 Remove unnecessary -fembed-bitcode usage now that it's deprecated This is a partial revert of 6d819a4 because rust-lang/cc-rs#812 removed this flag entirely, meaning we shouldn't have to pass this manually anymore
RalfJung
pushed a commit
to RalfJung/miri
that referenced
this pull request
May 22, 2024
…age-now-that-it-s-deprecated, r=clubby789 Remove unnecessary -fembed-bitcode usage now that it's deprecated This is a partial revert of 6d819a4b8f45b170e7c2c415df20cfa2e0cbbf7f because rust-lang/cc-rs#812 removed this flag entirely, meaning we shouldn't have to pass this manually anymore
flip1995
pushed a commit
to flip1995/rust-clippy
that referenced
this pull request
May 24, 2024
…age-now-that-it-s-deprecated, r=clubby789 Remove unnecessary -fembed-bitcode usage now that it's deprecated This is a partial revert of 6d819a4 because rust-lang/cc-rs#812 removed this flag entirely, meaning we shouldn't have to pass this manually anymore
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Jun 20, 2024
…age-now-that-it-s-deprecated, r=clubby789 Remove unnecessary -fembed-bitcode usage now that it's deprecated This is a partial revert of 6d819a4b8f45b170e7c2c415df20cfa2e0cbbf7f because rust-lang/cc-rs#812 removed this flag entirely, meaning we shouldn't have to pass this manually anymore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apple has recently stopped accepting apps built with any Xcode version below 14.1, and rejects apps built with bitcode starting with Xcode 14.