fix(flag_check): never link to avoid false positives #839
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using
flag_if_supported
when targetingwasm32-unknown-unknown
often (or maybe always) results in false negatives, causing supported flags to not be applied. This happens, becauseclang
is trying to link the binary withwasm-ld
which must be installed, and even withwasm-ld
installedclang
still gives me this error:This is easily avoided by telling clang to skip linking by using
-c
.