Support use of namespaced environment variables based on "TARGET" and "HOST" #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .collect::<Vec<&str>>() | ||
| .connect("_"); | ||
| let kind = os::getenv("BUILD_KIND") | ||
| .expect("Environment variable 'BUILD_KIND' is unset"); |
There was a problem hiding this comment.
This may need to be updated for HOST instead of BUILD_KIND now
|
This looks awesome @jmesmon, thanks! And especially thanks for writing up some docs! |
|
Updated to use the HOST variable instead of the withdrawn BUILD_KIND variable |
codyps
changed the title
|
Thanks! |
alexcrichton
added a commit
that referenced
this pull request
Dec 5, 2014
Support use of namespaced environment variables based on "TARGET" and "HOST"
This was referenced Mar 1, 2022
Remove most of the logic in fake rustc once
-Ztarget-applies-to-host=true lands
rust-lang/rust#94556
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a replacement for rust-lang/cargo#1004 and depends on http://github.com/rust-lang/cargo/pull/1008