-
Notifications
You must be signed in to change notification settings - Fork 451
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move Windows code into a module #924
Conversation
fdf4f07
to
98cc46e
Compare
mod windows; | ||
// Regardless of whether this should be in this crate's public API, | ||
// it has been since 2015, so don't break it. | ||
pub use windows::find_tools as windows_registry; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe make this #[doc(hidden)]
?
749b0f7
to
e477458
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, overall it LGTM but has two minor suggestions.
Also, can you please run gen-windows-sys-binding locally to make sure it works with the changed location?
Ah yeah, it needed a little adjustment since moving gen-windows-sys-binding to the dev-tools directory in #927. Now it works regardless of how you run gen-windows-sys-binding. |
This is easier to navigate now:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
No description provided.