Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use full import path in tool module #933

Merged
merged 1 commit into from
Jan 30, 2024
Merged

use full import path in tool module #933

merged 1 commit into from
Jan 30, 2024

Conversation

Be-ing
Copy link
Contributor

@Be-ing Be-ing commented Jan 30, 2024

instead of relying on use command_helpers::*; in lib.rs

@Be-ing
use full import path in tool module
c4b6ff1 
instead of relying on `use command_helpers::*;` in lib.rs
NobodyXu
NobodyXu approved these changes Jan 30, 2024
View reviewed changes
Copy link
Collaborator

@NobodyXu NobodyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@NobodyXu NobodyXu merged commit 46fdb0b into rust-lang:main Jan 30, 2024
18 checks passed
@Be-ing Be-ing deleted the tool_mod_import branch January 30, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NobodyXu NobodyXu NobodyXu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Be-ing @NobodyXu