Add integration test for unwind safety #407
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marmeladema
force-pushed
the
issue260/unwind-safety-test
branch
from
8051ba8
to
f706742
Compare
jackh726
reviewed
Apr 19, 2020
|
|
||
| #[derive(Debug, Default)] | ||
| struct MockDatabase { | ||
| chalk_db: ChalkDatabase, |
There was a problem hiding this comment.
I don't think we actually want to wrap an actual database.
| } | ||
| } | ||
|
|
||
| impl RustIrDatabase<ChalkIr> for MockDatabase { |
There was a problem hiding this comment.
For these methods, I was thinking just hardcode what we want to return for trait Foo and struct Bar
| use std::panic; | ||
|
|
||
| // lower program | ||
| let mut db = lower_program_with_db! { |
There was a problem hiding this comment.
So, we won't actually "lower" anything, it'll just be hardcoded.
| let program = db.chalk_db.checked_program().unwrap(); | ||
|
|
||
| // lower goal | ||
| let goal = lower_goal! { |
There was a problem hiding this comment.
Similarly here. We aren't going to "lower" this, we'll just manually create the UCanonicalGoalInEnvironment for Foo: Bar
Comment on lines
+150
to
+159
| // solve goal but this will panic | ||
| db.panic = true; | ||
| let result = panic::catch_unwind(|| { | ||
| db.solve(&peeled_goal); | ||
| }); | ||
| assert!(result.is_err() == true); | ||
|
|
||
| // solve again but without panicking this time | ||
| db.panic = false; | ||
| assert!(db.solve(&peeled_goal).is_some()); |
There was a problem hiding this comment.
This is exactly what I was thinking :)
| @@ -1,15 +1,35 @@ | |||
| #![allow(unused_macros)] | |||
|
|
|||
| macro_rules! lowering_success { | |||
| (program $program:tt) => { | |||
| macro_rules! lower_program_with_db { | |||
There was a problem hiding this comment.
I don't think we want to change/use anything here.
|
Closing in favor of #462 Thanks for the initial work here though :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This currently does not work because when the panic triggers, the solver lock is poisoned and i am not aware of a way to force un-poisoning it.
One approach that i've tried and that work, is to lock the solver outside of
catch_unwindbut this requires to useAssertUnwindSafeto use the lock guard insidecatch_unwindand that kind of defeats the whole purpose of that test.Fixes #260