Coinduction handling for recursive solver #698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikomatsakis
requested changes
Apr 2, 2021
nikomatsakis
reviewed
Apr 4, 2021
firefighterduck
force-pushed
the
coinductive-recursive-false-positives
branch
2 times, most recently
from
26f7874
to
40a5014
Compare
nikomatsakis
requested changes
Apr 11, 2021
There was a problem hiding this comment.
Code looks great! Here are some nits on the write-up. I might like to read it over one more time, or maybe @jackh726 can read it and see if he understands it.
add new tests for coinduction handling
add solution0 document solution0 and remove unecessary test cases simplify according to review
firefighterduck
force-pushed
the
coinductive-recursive-false-positives
branch
from
40a5014
to
e98a14f
Compare
jackh726
approved these changes
Apr 11, 2021
There was a problem hiding this comment.
Bravo. Reading through this, I realize I have so little knowledge about the recursive solver and how it works. But the documentation here is splendid. I'm not sure I can fully grok the code changes and their implications, but nothing sticks out as wrong to me.
nikomatsakis
approved these changes
Apr 12, 2021
|
r=me once tests are done! Nice work @firefighterduck! |
|
@bors r+ |
|
📌 Commit 9ce2cef has been approved by |
|
Forgot we use bors now |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is meant to address the issue of invalid result in coinductive cycles as described in #399 . It also fixes the two coinduction tests related to that issue (i.e. coinductive_unsound1 and coinductive_multicycle4). As such it is an improved version of #683 as it uses "solution0" described here and discussed here to handle more complicated coinductive cycles.