Fix cross compilation on android armv7 and x86 #186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the following cmake errors ``` Android: Unknown processor CMAKE_SYSTEM_PROCESSOR='x86'. ``` and ``` Android: Unknown processor CMAKE_SYSTEM_PROCESSOR='arm'. ``` when crosscompiling for `i686-linux-android` and `armv7-linux-androideabi` android targets fixes rust-lang#175
|
the ci fails on mips crosscompile test as rustup can't download those targets that were retrogaded to tier 3 rust-lang/compiler-team#648 |
|
I confirm this solves issues cross-compiling for Android, would love to see this merged |
|
Yes, this solves the issue (I can confirm for |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the following cmake errors
and
when crosscompiling for
i686-linux-androidandarmv7-linux-androideabiandroid targetsfixes #175