Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a way to test more targets on non-linux machines #591

Merged
merged 2 commits into from
Apr 19, 2024
Merged

Add a way to test more targets on non-linux machines #591

merged 2 commits into from
Apr 19, 2024

Conversation

tgross35
Copy link
Contributor

@tgross35 tgross35 commented Apr 13, 2024 •
edited
Loading

Allow using the rust-lang/rust:nightly docker image to run tests in cases where the host rust and cargo cannot be used, such as non-linux hosts.

Additionally, prefix image tags and the target directory with builtins- to reduce the chance of an accidental conflict, and fix shellcheck warnings.

@tgross35 tgross35 force-pushed the testing-updates branch 2 times, most recently from d0a2be1 to 56a404f Compare April 13, 2024 08:24
@tgross35
Copy link
Contributor Author

https://github.com/rust-lang/compiler-builtins/actions/runs/8672263156/job/23782359199?pr=591#step:8:2321 I have no clue why powerpc would have started failing because of this

@tgross35 tgross35 mentioned this pull request Apr 13, 2024
Closed
@tgross35 tgross35 force-pushed the testing-updates branch 10 times, most recently from 1ab5188 to c4a5cd0 Compare April 13, 2024 09:10
@tgross35
Copy link
Contributor Author

I guess the error was expected (?) based on previous runs https://github.com/rust-lang/compiler-builtins/actions/runs/8672321314/job/23782498611?pr=592#step:8:2165, and I just accidentally enabled it. Since powerpc is the only architecture that fails, I made it an xfail but left the tests enabled.

@tgross35 tgross35 marked this pull request as draft April 15, 2024 18:57
@tgross35 tgross35 force-pushed the testing-updates branch 9 times, most recently from 0b79be8 to b99d69d Compare April 15, 2024 19:50
@tgross35 tgross35 marked this pull request as ready for review April 15, 2024 19:52
@tgross35 tgross35 force-pushed the testing-updates branch 2 times, most recently from 572fcec to ff081be Compare April 16, 2024 07:26
@tgross35 tgross35 changed the title Add a way to run tests on non-linux machines Add a way to test more targets on non-linux machines Apr 16, 2024
Amanieu
Amanieu reviewed Apr 19, 2024
View reviewed changes
.gitignore
@@ -1,3 +1,6 @@
*.rs.bk
Cargo.lock
target
target-docker
compiler-rt
*.tar.gz
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think these changes should be committed. Maybe only the compiler-rt one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, target-docker was from before I changed it to just use a docker volume. Removed this.

tar.gz is just there so if you download the C libraries like in CI it won't get picked up. Is this okay to keep?

@tgross35
Add a way to run tests on non-linux machines
d2c3a16 
Allow using the `rust-lang/rust:nightly` docker image to run tests in
cases where the host rust and cargo cannot be used, such as non-linux
hosts.
@tgross35
Apply some more fixes suggested by Shellcheck
656928f
@Amanieu Amanieu merged commit 2705081 into rust-lang:master Apr 19, 2024
23 checks passed
@tgross35 tgross35 deleted the testing-updates branch April 19, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Amanieu Amanieu Amanieu left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tgross35 @Amanieu