Add a way to test more targets on non-linux machines #591
Conversation
tgross35
force-pushed
the
testing-updates
branch
2 times, most recently
from
d0a2be1
to
56a404f
Compare
|
https://github.com/rust-lang/compiler-builtins/actions/runs/8672263156/job/23782359199?pr=591#step:8:2321 I have no clue why powerpc would have started failing because of this |
tgross35
force-pushed
the
testing-updates
branch
10 times, most recently
from
1ab5188
to
c4a5cd0
Compare
|
I guess the error was expected (?) based on previous runs https://github.com/rust-lang/compiler-builtins/actions/runs/8672321314/job/23782498611?pr=592#step:8:2165, and I just accidentally enabled it. Since powerpc is the only architecture that fails, I made it an xfail but left the tests enabled. |
tgross35
force-pushed
the
testing-updates
branch
from
3afdaf8
to
6026476
Compare
tgross35
force-pushed
the
testing-updates
branch
9 times, most recently
from
0b79be8
to
b99d69d
Compare
tgross35
force-pushed
the
testing-updates
branch
2 times, most recently
from
572fcec
to
ff081be
Compare
tgross35
changed the title
| @@ -1,3 +1,6 @@ | |||
| *.rs.bk | |||
| Cargo.lock | |||
| target | |||
| target-docker | |||
| compiler-rt | |||
| *.tar.gz | |||
There was a problem hiding this comment.
I don't think these changes should be committed. Maybe only the compiler-rt one?
There was a problem hiding this comment.
Ah, target-docker was from before I changed it to just use a docker volume. Removed this.
tar.gz is just there so if you download the C libraries like in CI it won't get picked up. Is this okay to keep?
Allow using the `rust-lang/rust:nightly` docker image to run tests in cases where the host rust and cargo cannot be used, such as non-linux hosts.
tgross35
force-pushed
the
testing-updates
branch
from
ff081be
to
656928f
Compare
Allow using the
rust-lang/rust:nightlydocker image to run tests in cases where the host rust and cargo cannot be used, such as non-linux hosts.Additionally, prefix image tags and the target directory with
builtins-to reduce the chance of an accidental conflict, and fix shellcheck warnings.