-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prioritize NoSpace
error more
#729
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like time 0.3.30 is broken
|
Skgland
force-pushed
the
no-space-left2
branch
4 times, most recently
from
May 31, 2024 20:43
d4e8a89
to
8dd7383
Compare
☔ The latest upstream changes (presumably #732) made this pull request unmergeable. Please resolve the merge conflicts. |
Skgland
force-pushed
the
no-space-left2
branch
from
August 24, 2024 16:26
8dd7383
to
b89fe6e
Compare
☔ The latest upstream changes (presumably #734) made this pull request unmergeable. Please resolve the merge conflicts. |
Skgland
force-pushed
the
no-space-left2
branch
from
August 25, 2024 20:25
b89fe6e
to
397f3f0
Compare
@bors r+ |
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement for #715
adjust the prioritization of
NoSpace
After this it will be prioritized above
DependsOn
CompilerError
NetworkAccess
CompilerDiagnosticChange
The later two are already spurious-regressions so only the reason will change.
The former two would previously result in a regression but now would be spurious-regressions.
I think this change is reasonable as no space will likely be the cause for the compiler error or the error in the dependency.
include the spurious regressions in the
retry-regressed-list.txt
Spurious failures might hide actual regressions, this gives them another chance at showing actual regressions.
Further more spurious regressions are usually not too many and re-running will in a lot of cases resolve the spurious failure.
Sort some
CommandError::IO(_)
into as betterFailureReason