Remove tokio support
#292
Merged
Remove tokio support
#292
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Seems reasonable to me, thanks for the PR! |
|
Can somebody please update the documentation on docs.rs and the REAME? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following discussion in #214
The current support is for tokio 0.1, which is very outdated.
Crate
async-compressionprovides async integration if needed, so rather than upgrading to the latest version of tokio, this is a blanket removal of the feature.This removal is a breaking change only if the feature is enabled, so I'm not sure how it should be tied to a version change.
I cannot find any dependent crate on crates.io which uses the
tokiofeature