Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies #1418

Closed
wants to merge 1 commit into from
Closed

Update dependencies #1418

wants to merge 1 commit into from

Conversation

taiki-e
Copy link
Member

@taiki-e taiki-e commented Jan 16, 2019

  • either 1.4 -> 1.5
  • num_cpus 1.8.0 -> 1.9
  • lazy_static 1.1.0 -> 1.2
  • syn 0.15.22 -> 0.15.25

This PR mainly updates minor versions of dependencies.
num_cpus and lazy_static seem to be stable enough, so I think that it is probably OK without specifying a patch version.
Also, non_camel_case_type warning was allowed in dtolnay/syn#563, so I would like to include updating syn.

@taiki-e
Copy link
Member Author

taiki-e commented Jan 16, 2019

Update of rand was split into #1425.

* either 1.4 -> 1.5
* num_cpus 1.8.0 -> 1.9
* lazy_static 1.1.0 -> 1.2
* syn 0.15.22 -> 0.15.25
@cramertj
Copy link
Member

What's the point of bumping the minimum required version of these dependencies? AFAICT all this would do is force end-users to update, without actually providing any new functionality here (since users would already get the newer versions by default in a cargo build w/o a lockfile or a cargo update).

@taiki-e
Copy link
Member Author

taiki-e commented Jan 22, 2019

(since users would already get the newer versions by default in a cargo build w/o a lockfile or a cargo update)

I wrote this PR because I found older versions in dependencies when I built it locally, but I seem to have forgotten this.

@taiki-e taiki-e closed this Jan 22, 2019
@taiki-e taiki-e deleted the dependencies branch January 22, 2019 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants