Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Host header omits non-default port numbers #405

Closed
mx-shift opened this issue Feb 25, 2019 · 4 comments
Closed

Host header omits non-default port numbers #405

mx-shift opened this issue Feb 25, 2019 · 4 comments

Comments

@mx-shift
Copy link

This was fixed in upstream libgit2 (libgit2/libgit2#4882) but libgit2-sys's submodule is pinned to a version before that.
@bhamail bhamail mentioned this issue Feb 26, 2019
Closed
@bhamail
Copy link
Contributor

bhamail commented Apr 24, 2019

ping. Anything I can do to help move this along?

@alexcrichton
Copy link
Member

Thanks for the report! For updates to the submodule it's all just done through PRs, and we can update the submodule at any time!

bhamail added a commit to bhamail/git2-rs that referenced this issue May 17, 2019
@bhamail
update submodule libgit2 new commit to fix 'Host header omits non-def…
3d823d3 
…ault port numbers' - rust-lang#405
@bhamail bhamail mentioned this issue May 17, 2019
Merged
@bhamail
Copy link
Contributor

bhamail commented May 17, 2019

I've created PR: #421 to update the submodule.
Please let me know if more is needed.

@ehuss
Copy link
Contributor

ehuss commented Jul 14, 2019

This appears to be fixed now.

@ehuss ehuss closed this as completed Jul 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@ehuss @alexcrichton @bhamail @mx-shift