-
Notifications
You must be signed in to change notification settings - Fork 391
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
0.13.1 causing an error in project using git2 #540
Comments
You can update libgit2-sys to the latest version to fix this ( @alexcrichton when bumping versions, should we probably update this line as well? Like this: diff --git a/Cargo.toml b/Cargo.toml
index c19830c..7232cf0 100644
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -20,7 +20,7 @@ url = "2.0"
bitflags = "1.1.0"
libc = "0.2"
log = "0.4.8"
-libgit2-sys = { path = "libgit2-sys", version = "0.12.0" }
+libgit2-sys = { path = "libgit2-sys", version = "0.12.2" }
[target."cfg(all(unix, not(target_os = \"macos\")))".dependencies]
openssl-sys = { version = "0.9.0", optional = true } |
@ehuss Perfect! |
@ehuss Without also updating the |
Fix the dependencies for git2 based on the suggestions from rust-lang/git2-rs#540.
* build(deps): bump git2 from 0.13.0 to 0.13.1 Bumps [git2](https://github.com/rust-lang/git2-rs) from 0.13.0 to 0.13.1. - [Release notes](https://github.com/rust-lang/git2-rs/releases) - [Commits](rust-lang/git2-rs@git2-curl-0.13.0...0.13.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix git2 build failures Fix the dependencies for git2 based on the suggestions from rust-lang/git2-rs#540. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Thomas O'Donnell <andy.tom@gmail.com>
* build(deps): bump git2 from 0.13.0 to 0.13.1 Bumps [git2](https://github.com/rust-lang/git2-rs) from 0.13.0 to 0.13.1. - [Release notes](https://github.com/rust-lang/git2-rs/releases) - [Commits](rust-lang/git2-rs@git2-curl-0.13.0...0.13.1) Signed-off-by: dependabot-preview[bot] <support@dependabot.com> * Fix git2 build failures Fix the dependencies for git2 based on the suggestions from rust-lang/git2-rs#540. Co-authored-by: dependabot-preview[bot] <27856297+dependabot-preview[bot]@users.noreply.github.com> Co-authored-by: Thomas O'Donnell <andy.tom@gmail.com>
Closing as I believe this is resolved. When updating the base crate to use new bindings, we'll be sure to also update the -sys dependency. |
Discovered 0.13.1 had released via
cargo outdated --root-deps-only
, then updated myCargo.toml
to havegit2 = "0.13.1"
, then observed the above error duringcargo build
.Short term workaround is to change
Cargo.toml
to havegit2 = "<0.13.1"
, which builds successfully with 0.13.0.Any ideas about the root cause and/or fix? Thanks in advance!
EDIT: OS: Debian Testing; libgit2-28, libgit2-dev not installed
EDIT:
The text was updated successfully, but these errors were encountered: