test for the Repository::config() function #651
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…onfig object that have the local repo as highest prio
src/repo.rs
Outdated
|
|
||
| #[test] | ||
| fn smoke_config_write_and_read() { | ||
| let td = TempDir::new().unwrap(); |
There was a problem hiding this comment.
There's a helper function used in other tests that creates a temporary directory and repository for you, in one call.
There was a problem hiding this comment.
Thanks for the quick feedback, I have updated the PR to use that.
alexanderkjall
force-pushed
the
smoke-test-config-method
branch
from
3b74a2c
to
8c24d47
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was debugging a thing, and thought that I could just as well push the test I wrote for debugging upstream.
This test verifies that the Repository::config() function returns a config object that have the local repository as highest prio.