Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing user_fpxregs_struct on musl x86 #3476

Closed
ptrcnull opened this issue Dec 11, 2023 · 1 comment · Fixed by #3477
Closed

Missing user_fpxregs_struct on musl x86 #3476

ptrcnull opened this issue Dec 11, 2023 · 1 comment · Fixed by #3477
Labels
C-API-request Category: API request

Comments

@ptrcnull
Copy link

user_fpxregs_struct does exist in musl, but doesn't seem to be available in the libc crate:

10:34.49 error[E0432]: unresolved import `libc::user_fpxregs_struct`
10:34.49  --> /builds/alpine/aports/community/firefox/src/firefox-120.0.1/third_party/rust/minidump-writer/src/linux/thread_info/x86.rs:5:5
10:34.49   |
10:34.49 5 | use libc::user_fpxregs_struct;
10:34.49   |     ^^^^^^^^^^^^^^^^^^^^^^^^^ no `user_fpxregs_struct` in the root
10:34.52 error[E0432]: unresolved imports `libc::user`, `libc::user_fpregs_struct`, `libc::user_regs_struct`
10:34.52  --> /builds/alpine/aports/community/firefox/src/firefox-120.0.1/third_party/rust/minidump-writer/src/linux/thread_info/x86.rs:7:12
10:34.52   |
10:34.52 7 | use libc::{user, user_fpregs_struct, user_regs_struct};
10:34.52   |            ^^^^  ^^^^^^^^^^^^^^^^^^  ^^^^^^^^^^^^^^^^ no `user_regs_struct` in the root
10:34.52   |            |     |
10:34.52   |            |     no `user_fpregs_struct` in the root
10:34.52   |            no `user` in the root
10:34.55 error[E0412]: cannot find type `_libc_fpreg` in crate `libc`
10:34.55   --> /builds/alpine/aports/community/firefox/src/firefox-120.0.1/third_party/rust/minidump-writer/src/linux/crash_context/x86.rs:53:71
10:34.55    |
10:34.55 53 |             debug_assert_eq!(fs._st.len() * std::mem::size_of::<libc::_libc_fpreg>(), 80);
10:34.55    |                                                                       ^^^^^^^^^^^ not found in `libc`
10:34.55 error[E0412]: cannot find type `_libc_fpreg` in crate `libc`
10:34.55   --> /builds/alpine/aports/community/firefox/src/firefox-120.0.1/third_party/rust/minidump-writer/src/linux/crash_context/x86.rs:57:62
10:34.55    |
10:34.55 57 |                     fs._st.len() * std::mem::size_of::<libc::_libc_fpreg>(),
10:34.55    |                                                              ^^^^^^^^^^^ not found in `libc`
@ptrcnull
Copy link
Author

it's been pointed out to me that it's not just fpxregs, but also user_fpregs_struct user_regs_struct and _libc_fpreg; the two former available in musl in the same file, but the latter doesn't seem to exist under the same name

bors added a commit that referenced this issue Dec 15, 2023
iadding yser_fpxregs_struct data to linux/musl i686.

close #3476
@bors bors closed this as completed in 1198797 Dec 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-API-request Category: API request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant