Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose futimens and utimensat on FreeBSD and DragonFly #1085

Merged
merged 1 commit into from
Sep 28, 2018

Conversation

jmmv
Copy link
Contributor

@jmmv jmmv commented Sep 25, 2018

Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944).

Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.

@rust-highfive
Copy link

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Sep 25, 2018

📌 Commit 622cc28 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Sep 25, 2018

⌛ Testing commit 622cc28 with merge 1fc3285...

bors added a commit that referenced this pull request Sep 25, 2018
Expose futimens and utimensat on FreeBSD and DragonFly

Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944).

Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
@bors
Copy link
Contributor

bors commented Sep 25, 2018

💔 Test failed - status-travis

@jmmv
Copy link
Contributor Author

jmmv commented Sep 26, 2018

The two failures in the Travis build look like flakes due to a network download issue. What's the process here? I do not have the permissions to make Travis re-run those two failed builds.

@alexcrichton
Copy link
Member

@bors: retry

Ah we just try again!

@bors
Copy link
Contributor

bors commented Sep 26, 2018

⌛ Testing commit 622cc28 with merge b7b5f71...

bors added a commit that referenced this pull request Sep 26, 2018
Expose futimens and utimensat on FreeBSD and DragonFly

Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944).

Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
@bors
Copy link
Contributor

bors commented Sep 26, 2018

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Sep 26, 2018

⌛ Testing commit 622cc28 with merge e6ed991...

bors added a commit that referenced this pull request Sep 26, 2018
Expose futimens and utimensat on FreeBSD and DragonFly

Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944).

Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
@bors
Copy link
Contributor

bors commented Sep 26, 2018

💔 Test failed - status-travis

@jmmv
Copy link
Contributor Author

jmmv commented Sep 26, 2018

@bors: retry

@bors
Copy link
Contributor

bors commented Sep 26, 2018

@jmmv: 🔑 Insufficient privileges: not in try users

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Sep 26, 2018

⌛ Testing commit 622cc28 with merge e81df8d...

bors added a commit that referenced this pull request Sep 26, 2018
Expose futimens and utimensat on FreeBSD and DragonFly

Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944).

Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
@bors
Copy link
Contributor

bors commented Sep 26, 2018

💔 Test failed - status-travis

@alexcrichton
Copy link
Member

@bors: retry

???

@bors
Copy link
Contributor

bors commented Sep 26, 2018

⌛ Testing commit 622cc28 with merge bff68bb...

bors added a commit that referenced this pull request Sep 26, 2018
Expose futimens and utimensat on FreeBSD and DragonFly

Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944).

Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
@bors
Copy link
Contributor

bors commented Sep 26, 2018

💥 Test timed out

@jmmv
Copy link
Contributor Author

jmmv commented Sep 26, 2018

This is unfortunate...

@jmmv
Copy link
Contributor Author

jmmv commented Sep 27, 2018

One last attempt today maybe? :-P

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Sep 27, 2018

⌛ Testing commit 622cc28 with merge 2575fe9...

bors added a commit that referenced this pull request Sep 27, 2018
Expose futimens and utimensat on FreeBSD and DragonFly

Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944).

Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
@bors
Copy link
Contributor

bors commented Sep 27, 2018

💔 Test failed - status-travis

@jmmv
Copy link
Contributor Author

jmmv commented Sep 27, 2018

This is sad :(

Wondering if it's possible to just hit retry on the individual Travis build failures in the hope that we can iterate faster and get the flakes through? Or maybe these builds should be marked non-fatal until they can be made to work again?

@alexcrichton
Copy link
Member

Unfortunately our CI doesn't work by retrying individual builds, I'll need to allocate some time to investigate and try to fix these android builds

@jmmv
Copy link
Contributor Author

jmmv commented Sep 28, 2018

Give it another try? I have created a test repository that downloads the problematic files on Travis, using the same settings as this project, and cannot reproduce it: https://travis-ci.org/jmmv/test/builds/434537625. So either something else is going on, or the problem has been resolved.

@alexcrichton
Copy link
Member

@bors: retry

Sure yeah, can always try that!

@bors
Copy link
Contributor

bors commented Sep 28, 2018

⌛ Testing commit 622cc28 with merge 2926a5b...

bors added a commit that referenced this pull request Sep 28, 2018
Expose futimens and utimensat on FreeBSD and DragonFly

Should have sent this out with #1084 but I didn't notice then that these were missing (see nix-rust/nix#944).

Haven't been able to test these locally as I do not have access to these platforms. Will rely on CI to verify these for me.
@bors
Copy link
Contributor

bors commented Sep 28, 2018

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 2926a5b to master...

@bors bors merged commit 622cc28 into rust-lang:master Sep 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants