Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate and Update Fuchsia #849

Merged
merged 3 commits into from
Nov 16, 2017
Merged

Conversation

cramertj
Copy link
Member

The first commit pulls Fuchsia out into its own directory, while the second commit updates the "open" flags as in #848.

cc @smklein, @alexcrichton

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 15, 2017

📌 Commit b4cfe88 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Nov 15, 2017

⌛ Testing commit b4cfe88 with merge a72a79b...

bors added a commit that referenced this pull request Nov 15, 2017
Separate and Update Fuchsia

The first commit pulls Fuchsia out into its own directory, while the second commit updates the "open" flags as in #848.

cc @smklein, @alexcrichton
@bors
Copy link
Contributor

bors commented Nov 16, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing a72a79b to master...

@bors bors merged commit b4cfe88 into rust-lang:master Nov 16, 2017
@cramertj
Copy link
Member Author

cramertj commented Nov 16, 2017

@alexcrichton Should I open a PR against rust-lang/rust updating the submodule, or is there a more official process for updating libc?

@alexcrichton
Copy link
Member

Nah that's it!

bors added a commit to rust-lang/rust that referenced this pull request Nov 19, 2017
Update libc to include Fuchsia changes

This is an update of libc to include the updated Fuchsia "open" flags added in rust-lang/libc#849.

cc @smklein
r? @alexcrichton
@@ -286,6 +286,9 @@ cfg_if! {
} else if #[cfg(target_os = "redox")] {
mod redox;
pub use redox::*;
} else if #[cfg(target_os = "fuchisa")] {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a typo: fuchisa, so this is likely not going to work.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gah! #854

@cramertj cramertj deleted the separate-fuchsia branch August 22, 2018 17:34
josephlr added a commit to josephlr/libc that referenced this pull request Jun 13, 2019
PR rust-lang#849 just moved all of the Linux structures into `src/fuchsia`.
While this is good for the most part, we really don't want the `SYS_*`
constants exported on Fushia, as these are not Fuchsia's syscalls.

This also removes Linux-specific `GRND_*` constants.
josephlr added a commit to josephlr/libc that referenced this pull request Jun 13, 2019
PR rust-lang#849 just moved all of the Linux structures into `src/fuchsia`.
While this is good for the most part, we really don't want the `SYS_*`
constants exported on Fushia, as these are not Fuchsia's syscalls.

This also removes Linux-specific `GRND_*` constants.
bors added a commit that referenced this pull request Jun 14, 2019
Remove Linux constants from Fushia

PR #849 just moved all of the Linux structures into `src/fuchsia`.
While this is good for the most part, we really don't want the `SYS_*`
constants exported on Fushia, as these are not Fuchsia's syscalls.

This also removes Linux-specific `GRND_*` constants.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants