-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate and Update Fuchsia #849
Conversation
@bors: r+ |
📌 Commit b4cfe88 has been approved by |
Separate and Update Fuchsia The first commit pulls Fuchsia out into its own directory, while the second commit updates the "open" flags as in #848. cc @smklein, @alexcrichton
☀️ Test successful - status-appveyor, status-travis |
@alexcrichton Should I open a PR against rust-lang/rust updating the submodule, or is there a more official process for updating libc? |
Nah that's it! |
Update libc to include Fuchsia changes This is an update of libc to include the updated Fuchsia "open" flags added in rust-lang/libc#849. cc @smklein r? @alexcrichton
@@ -286,6 +286,9 @@ cfg_if! { | |||
} else if #[cfg(target_os = "redox")] { | |||
mod redox; | |||
pub use redox::*; | |||
} else if #[cfg(target_os = "fuchisa")] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a typo: fuchisa
, so this is likely not going to work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gah! #854
PR rust-lang#849 just moved all of the Linux structures into `src/fuchsia`. While this is good for the most part, we really don't want the `SYS_*` constants exported on Fushia, as these are not Fuchsia's syscalls. This also removes Linux-specific `GRND_*` constants.
PR rust-lang#849 just moved all of the Linux structures into `src/fuchsia`. While this is good for the most part, we really don't want the `SYS_*` constants exported on Fushia, as these are not Fuchsia's syscalls. This also removes Linux-specific `GRND_*` constants.
Remove Linux constants from Fushia PR #849 just moved all of the Linux structures into `src/fuchsia`. While this is good for the most part, we really don't want the `SYS_*` constants exported on Fushia, as these are not Fuchsia's syscalls. This also removes Linux-specific `GRND_*` constants.
The first commit pulls Fuchsia out into its own directory, while the second commit updates the "open" flags as in #848.
cc @smklein, @alexcrichton