Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a method to set the active logging filters post-initialization. #11

Closed
DiamondLovesYou opened this issue Jan 23, 2015 · 0 comments · Fixed by #12
Closed

Add a method to set the active logging filters post-initialization. #11

DiamondLovesYou opened this issue Jan 23, 2015 · 0 comments · Fixed by #12

Comments

@DiamondLovesYou
Copy link

For example, in Chrome PNaCl applications, access to host environmental vars is completely restricted. Thus all logging code in those applications are effectively dead code.

It would be great if I could enable logging by, for example, adding a DOM attribute (which turns into an argument provide to the PPP_InstanceCreated callback) of the module before it's attached to the DOM (thereby creating the instance). Also, note PPP_InstanceCreated is not where rust-ppapi initializes std, so this needs to allow users to set the desired filter value after initialization. Doesn't need to be thread-safe, but should probably include a warning label.

This represents a nice-to-have feature.

sfackler added a commit to sfackler/log that referenced this issue Jan 25, 2015
sfackler added a commit to sfackler/log that referenced this issue Jan 25, 2015
sfackler added a commit to sfackler/log that referenced this issue Jan 25, 2015
sfackler added a commit to sfackler/log that referenced this issue Jan 25, 2015
sfackler added a commit to sfackler/log that referenced this issue Jan 25, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant