-
Notifications
You must be signed in to change notification settings - Fork 253
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Thumbv6 support #325
Merged
Merged
Thumbv6 support #325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfackler
reviewed
Mar 19, 2019
@sfackler Does this look better to you? I'm not terribly good at writing docs. |
sfackler
reviewed
Mar 25, 2019
sfackler
reviewed
Mar 25, 2019
LGTM with 2 more little doc nits! |
Any update? |
Oh sorry, didn't notice that last commit! |
EFanZh
pushed a commit
to EFanZh/log
that referenced
this pull request
Jul 23, 2023
…stead of `HashMap`. Signed-off-by: Jiahao XU <Jiahao_XU@outlook.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #285, this adds another initialization function,
set_logger_racy
, which doesn't usecompare_and_swap
and is unsafe.This allows
log
to support platforms that lack CAS support, which includesthumbv6
. I haven't added any other architecture since I don't know how the exact support matrix for atomics looks.Closes #285