fix: ayu theme meta highlighting #1133
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Failure seems related to the issue fixed via #1131 . |
|
@Byron - I don't think so? Willing to be corrected but this seems like an issue with the css. I've updated my submission to include reference screenshots. |
ehuss
approved these changes
Feb 1, 2020
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
…x-derive-highlighting fix: ayu theme meta highlighting
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was previously highlighting
#[derive(Clone)]like it was a comment. This updates the css to match the grouping of other themes.For an example see https://rust-lang.github.io/async-book/02_execution/04_executor.html. Note the
#[derive(Clone)]highlighting color in line 7 of the following screenshotsFor reference, here is the regular theme:
And here is the ayu theme today:
And here is the ayu theme after the change proposed in this PR: