Don't copy default favicon if at least one is overridden. #1266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuss
added a commit
to ehuss/mdBook
that referenced
this pull request
Jul 8, 2020
A mistake in rust-lang#1266, I neglected to also update the <link> generation to elide the link if one of the favicon images is not included.
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Don't copy default favicon if at least one is overridden.
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
A mistake in rust-lang#1266, I neglected to also update the <link> generation to elide the link if one of the favicon images is not included.
rubenmoor
pushed a commit
to rubenmoor/mdBook
that referenced
this pull request
Aug 5, 2022
A mistake in rust-lang#1266, I neglected to also update the <link> generation to elide the link if one of the favicon images is not included.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has overridden one favicon format (SVG or PNG), don't copy the default for the other.
Books may override PNG, but not have a convenient SVG version that they want to use.