Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support space as seperator between language and additional class in c… #1469

Merged
merged 3 commits into from
Jul 10, 2021

Conversation

tuyen-at-work
Copy link
Contributor

…ode block

This PR try to resolve this issue: #1384

@ehuss
Copy link
Contributor

ehuss commented Feb 21, 2021

Thanks! It looks like rustdoc will be making a similar change (rust-lang/rust#78429). Maybe this should match its behavior and also support the tab character? (I don't think it should bother with the curly brace issue.)
Unfortunately, per rust-lang/rust#78429 (comment), it doesn't seem like there is much agreement on how this should work, but spaces and tabs seem reasonable. I'd also like to wait until the rustdoc changes land.

@tuyen-at-work
Copy link
Contributor Author

@ehuss as your comment, GitHub supports ,, space and \t. VS Code supports space and \t but not ,. They are the biggest guys in the market. So I think it is most flexible to support all 3 chars, like GitHub does. I think as long as GitHub supports it, other implementation will follow suits.

@jyn514
Copy link
Member

jyn514 commented Feb 25, 2021

Thanks! It looks like rustdoc will be making a similar change (rust-lang/rust#78429). Maybe this should match its behavior and also support the tab character?

Just to clarify - rustdoc already splits on spaces (in fact, it splits on almost anything that's not a letter). rust-lang/rust#78429 is removing delimiters, not adding more.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went ahead and pushed a change to add tab to be consistent with rustdoc and GitHub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants