Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add page-break #1485

Merged
merged 2 commits into from
Mar 17, 2021
Merged

Add page-break #1485

merged 2 commits into from
Mar 17, 2021

Conversation

Evian-Zhang
Copy link
Contributor

This is a new version of old pr #1300, since that one is out-dated.

This pr adds a page-break option, when printing the generated book to PDF, page breaks will be inserted between chapters, so that a new chapter will start at a new page. This option is default to be true. For implement details, please see content of old pr.

@ehuss
Copy link
Contributor

ehuss commented Mar 15, 2021

Thanks for following up. There was a question in the previous PR: Why make the page-break an option? Why not just have this on all the time?

@Evian-Zhang Evian-Zhang changed the title Add page-break option Add page-break Mar 16, 2021
@Evian-Zhang
Copy link
Contributor Author

@ehuss Fixed it.

Copy link
Contributor

@ehuss ehuss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ehuss ehuss merged commit e6568a7 into rust-lang:master Mar 17, 2021
@intptr-t intptr-t mentioned this pull request Jun 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants