Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Opening a PR to initiate discussion.
Everything is there and working, but there are a few things I dislike/am unsure of.
default-theme
is confusing to the user. The options are presented as 'themes' to the visitor in the theme popup, but from a user's perspective the theme is the whole theme insidesrc\theme
. Maybe this should bedefault-style
ordefault-theme-style
? Maybe I just need to explain the option better in the documentation?(default)
to the selected default theme in the theme popup. Originally I had done this in the javascript that sets the theme on page load, but it seemed a bit hacky when we know which theme is the default during render. Not sure if this is the best way, or best implementation of a helper though.Once complete this will resolve #95 and #713