Update toml. #945
Merged
Update toml. #945
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tesuji
reviewed
May 30, 2019
src/lib.rs
Outdated
| @@ -151,6 +147,12 @@ pub mod errors { | |||
| description("Reserved Filename") | |||
| display("{} is reserved for internal use", filename.display()) | |||
| } | |||
|
|
|||
| /// Error with a TOML file. | |||
| TomlQueryError(inner: ::toml_query::error::Error) { | |||
There was a problem hiding this comment.
We don't need leading :: before crate name in 2018 edition.
There was a problem hiding this comment.
Oh, yea, I was just copy/pasting, and keeping the style. I noticed all the leading :: and thought it was odd. I'll update after #944.
|
This should close #938 . |
Just keeping up-to-date.
tesuji
approved these changes
May 31, 2019
Ruin0x11
pushed a commit
to Ruin0x11/mdBook
that referenced
this pull request
Aug 30, 2020
Just keeping up-to-date.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just keeping up-to-date.
Closes #938.