Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add eventfd shim #3650

Merged
merged 1 commit into from
Jun 8, 2024
Merged

Add eventfd shim #3650

merged 1 commit into from
Jun 8, 2024

Conversation

tiif
Copy link
Contributor

@tiif tiif commented Jun 6, 2024

@tiif
Copy link
Contributor Author

tiif commented Jun 6, 2024

@rustbot ready

@rustbot rustbot added the S-waiting-on-review Status: Waiting for a review to complete label Jun 6, 2024
@tiif tiif requested a review from oli-obk June 7, 2024 17:31
oli-obk
oli-obk approved these changes Jun 7, 2024
View reviewed changes
Copy link
Contributor

@oli-obk oli-obk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please squash the commits

@oli-obk
Copy link
Contributor

oli-obk commented Jun 8, 2024

@bors r+

@bors
Copy link
Collaborator

bors commented Jun 8, 2024

📌 Commit 2f206fa has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Collaborator

bors commented Jun 8, 2024

⌛ Testing commit 2f206fa with merge c51b733...

@bors
Copy link
Collaborator

bors commented Jun 8, 2024

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing c51b733 to master...

@bors bors merged commit c51b733 into rust-lang:master Jun 8, 2024
8 checks passed
RalfJung
RalfJung reviewed Jun 8, 2024
View reviewed changes
Copy link
Member

@RalfJung RalfJung left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
I found some comment and test nits, would be nice if you could file a follow-up PR for that. :)

src/shims/unix/linux/eventfd.rs Show resolved Hide resolved
src/shims/unix/linux/eventfd.rs Show resolved Hide resolved
src/shims/unix/linux/eventfd.rs Show resolved Hide resolved
src/shims/unix/linux/eventfd.rs Show resolved Hide resolved
src/shims/unix/linux/eventfd.rs Show resolved Hide resolved
src/shims/unix/linux/eventfd.rs Show resolved Hide resolved
tests/fail-dep/libc/libc_eventfd_read_block.rs Show resolved Hide resolved
tests/pass-dep/libc/libc-eventfd.rs Show resolved Hide resolved
tests/pass-dep/libc/libc-eventfd.rs Show resolved Hide resolved
@tiif tiif mentioned this pull request Jun 9, 2024
Merged
bors added a commit that referenced this pull request Jun 9, 2024
@bors
Auto merge of #3661 - tiif:fix/eventfd, r=RalfJung
1eb9bae 
Follow up PR for eventfd shim

Follow up of #3650
RalfJung pushed a commit to RalfJung/rust that referenced this pull request Jun 9, 2024
@bors
Auto merge of rust-lang#3661 - tiif:fix/eventfd, r=RalfJung
ad85a20 
Follow up PR for eventfd shim

Follow up of rust-lang/miri#3650
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RalfJung RalfJung RalfJung left review comments

@oli-obk oli-obk oli-obk approved these changes

Assignees
No one assigned
Labels
S-waiting-on-review Status: Waiting for a review to complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Complete and fix our eventfd implementation
5 participants
@tiif @oli-obk @bors @RalfJung @rustbot