Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Never pick up strawberry perl's pkg-config as a valid pkg-config #164

Closed
nirbheek opened this issue Apr 4, 2024 · 1 comment · May be fixed by #165
Closed

Never pick up strawberry perl's pkg-config as a valid pkg-config #164

nirbheek opened this issue Apr 4, 2024 · 1 comment · May be fixed by #165

Comments

@nirbheek
Copy link

nirbheek commented Apr 4, 2024

Strawberry Perl places a pkg-config.bat into PATH that is written in Perl and is not intended to be used by third parties as a MinGW distribution. This wouldn't matter, except that Strawberry Perl is also included in Github CI images out of the box, in PATH, and it breaks everyone's CI jobs.

This is already done by Meson and CMake.

Just filing this as an issue so I can link to it from rust-lang/rust#123436 for now, will open a PR to fix this later.

nirbheek added a commit to nirbheek/pkg-config-rs that referenced this issue Apr 6, 2024
Strawberry Perl places a `pkg-config.bat` into PATH that is written in
Perl and is not intended to be used by third parties as a MinGW
distribution. This wouldn't matter, except that Strawberry Perl is
also included in Github CI images out of the box, in `PATH`, and it
breaks everyone's CI jobs.

This is already done by Meson and CMake:

mesonbuild/meson#9384

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9375

Fixes rust-lang#164
nirbheek added a commit to nirbheek/pkg-config-rs that referenced this issue Apr 7, 2024
Strawberry Perl places a `pkg-config.bat` into PATH that is written in
Perl and is not intended to be used by third parties as a MinGW
distribution. This wouldn't matter, except that Strawberry Perl is
also included in Github CI images out of the box, in `PATH`, and it
breaks everyone's CI jobs.

This is already done by Meson and CMake:

mesonbuild/meson#9384

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9375

Fixes rust-lang#164
nirbheek added a commit to nirbheek/pkg-config-rs that referenced this issue Apr 7, 2024
Strawberry Perl places a `pkg-config.bat` into PATH that is written in
Perl and is not intended to be used by third parties as a MinGW
distribution. This wouldn't matter, except that Strawberry Perl is
also included in Github CI images out of the box, in `PATH`, and it
breaks everyone's CI jobs.

This is already done by Meson and CMake:

mesonbuild/meson#9384

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9375

Fixes rust-lang#164
nirbheek added a commit to nirbheek/pkg-config-rs that referenced this issue Apr 7, 2024
Strawberry Perl places a `pkg-config.bat` into PATH that is written in
Perl and is not intended to be used by third parties as a MinGW
distribution. This wouldn't matter, except that Strawberry Perl is
also included in Github CI images out of the box, in `PATH`, and it
breaks everyone's CI jobs.

This is already done by Meson and CMake:

mesonbuild/meson#9384

https://gitlab.kitware.com/cmake/cmake/-/merge_requests/9375

Fixes rust-lang#164
@nirbheek
Copy link
Author

nirbheek commented Apr 7, 2024

This is apparently not an issue due to pre-existing bugs in std::process::Command: rust-lang/rust#37519

@nirbheek nirbheek closed this as completed Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant