Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How to make ABI compatible between crates.io release and rustc_smir #27

Open
Tracked by #30
celinval opened this issue Sep 1, 2023 · 2 comments
Open
Tracked by #30

How to make ABI compatible between crates.io release and rustc_smir #27

celinval opened this issue Sep 1, 2023 · 2 comments

Comments

@celinval
Copy link
Contributor

celinval commented Sep 1, 2023

In order to release StableMIR, we need to ensure compatibility between the compiler data structures and the published crate.
@celinval
Copy link
Contributor Author

celinval commented Sep 1, 2023

@oli-obk raised an important concern:

I have a concern with the crates.io release. It will either break (because we ship the Context impl in it, and thus the usage of the non SMIR rustc APIs), or it doesn't use any non-SMIR APIs, but then the data structures are incompatible with the ones shipped by rustc

@celinval celinval mentioned this issue Sep 1, 2023
Open
@oli-obk oli-obk mentioned this issue Sep 18, 2023
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this issue Sep 27, 2023
@matthiaskrgr
Rollup merge of rust-lang#115934 - oli-obk:smir_identity, r=spastorino
d485887 
Split out the stable part of smir into its own crate to prevent accidental usage of forever unstable things

Some groundwork for being able to work on rust-lang/project-stable-mir#27 at all

r? `@spastorino`
rust-timer added a commit to rust-lang-ci/rust that referenced this issue Sep 27, 2023
@rust-timer
Unrolled build for rust-lang#115934
e7dc444 
Rollup merge of rust-lang#115934 - oli-obk:smir_identity, r=spastorino

Split out the stable part of smir into its own crate to prevent accidental usage of forever unstable things

Some groundwork for being able to work on rust-lang/project-stable-mir#27 at all

r? `@spastorino`
@celinval
Copy link
Contributor Author

I documented the current proposal here: https://hackmd.io/jBRkZLqAQL2EVgwIIeNMHg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@celinval