Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify how to use ascii character classes in [..] #286

Closed
wants to merge 1 commit into from
Closed

Clarify how to use ascii character classes in [..] #286

wants to merge 1 commit into from

Conversation

matklad
Copy link
Member

@matklad matklad commented Sep 27, 2016

No description provided.

@matklad
Copy link
Member Author

matklad commented Sep 27, 2016

See also #287 :)

@BurntSushi
Copy link
Member

This is actually related to #175. If we merge this, I'd guess we are committing to this syntax. Which doesn't seem that bad.

@matklad
Copy link
Member Author

matklad commented Sep 27, 2016

Hm, if [:alpha:] is not a character class by itself, then there is no confusion at all. So looks like changing [:alpha:] to [[:alpha:]] would be a more fundamental fix for the problem.

@BurntSushi
Copy link
Member

@matklad I'm going to fix #175 instead, so I think we can close this. Thanks anyway!

@BurntSushi BurntSushi closed this Nov 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matklad @BurntSushi