Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unicode license for the unicode tables in regex-syntax #530

Closed
erickt opened this issue Oct 24, 2018 · 4 comments
Closed

Add unicode license for the unicode tables in regex-syntax #530

erickt opened this issue Oct 24, 2018 · 4 comments

Comments

@erickt
Copy link

erickt commented Oct 24, 2018

We noticed that regex-syntax uses tables derived from unicode 11, but the license files don't include a reference to the unicode terms of use. Could this be added? Thanks so much!
@BurntSushi
Copy link
Member

In principle this sounds fine to me. But I don't actually know what the requirements are here though. What, specifically, is needed? Reading your link, I don't think I see any requirement to link to those terms of use? Moreover, it's not clear to me whether data derived from Unicode's tables falls under those terms of use.

@cgonyeo
Copy link
Contributor

cgonyeo commented Oct 26, 2018

We need the license terms around that data to be clear, and the unicode terms of use state that their data can be modified and distributed only if their copyright and permission notice appears with "all copies
of the Data Files or Software", or is "in associated Documentation".

(I'm assuming derived == modified here, I'm not a lawyer though)

@cgonyeo
Copy link
Contributor

cgonyeo commented Nov 6, 2018

I guess the root of this is the question "did the data in this directory come from the unicode consortium"? If not, great. If it did, we'd love it if you could include that license. I can make a pull request to add it if that helps.

@BurntSushi
Copy link
Member

It did. A PR would be welcome.

cgonyeo pushed a commit to cgonyeo/regex that referenced this issue Nov 7, 2018
license: add the unicode license for unicode-tables
25e0c0b 
Add the Unicode license to the unicode-tables directory, as the data
there comes from the Unicode Consortium.

Fixes rust-lang#530
@cgonyeo cgonyeo mentioned this issue Nov 7, 2018
Merged
cgonyeo pushed a commit to cgonyeo/regex that referenced this issue Nov 7, 2018
license: add the unicode license for unicode-tables
bbd298e 
Add the Unicode license to the unicode-tables directory, as the data
there comes from the Unicode Consortium.

Fixes rust-lang#530
cgonyeo pushed a commit to cgonyeo/regex that referenced this issue Nov 7, 2018
license: add the unicode license for unicode-tables
b3a9821 
Add the Unicode license to the unicode-tables directory, as the data
there comes from the Unicode Consortium.

Fixes rust-lang#530
BurntSushi pushed a commit that referenced this issue Nov 7, 2018
@BurntSushi
syntax/license: add the unicode license for unicode-tables
ce41543 
Add the Unicode license to the unicode-tables directory, as the data
there comes from the Unicode Consortium.

Fixes #530
@cgonyeo cgonyeo mentioned this issue Nov 8, 2018
Merged
@BurntSushi BurntSushi mentioned this issue Sep 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erickt @BurntSushi @cgonyeo