-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove files with contributions from the people where no approval of the licensing terms was received #2193
Conversation
This reverts commit 938ff6d, apparently their only contribution to this repository.
Now every file currently in the repository is licensed under those terms!
Removing accepted RFCs from the repo seems very very wrong to me. Much worse than having a small subset of files with an unclear license. |
I would just add a |
My PR doesn't remove the RFCs from the repo, only from the master branch. If you go back in history, the files are still available. You can still link to them, inspect them, etc. A full clone of the git repo will still contain the files as blobs. You can do deletion from the history as well with git (requiring force pushes and breaking sha1 hashes), but it's not what I'm proposing in my PR. Removing them from the master branch will mean that we prevent accidental infringement like e.g. if we opt to host a rendered version of the RFCs on doc.rust-lang.org. IANAL, but from my guess it seems that hosting them through Github Pages (like #2192 proposes it) would be okay as it's covered by the license the contributors granted through the TOS to Github, while hosting them on EC2 where doc.rust-lang.org is might get us into trouble already. |
Sure they’re in the git history, but IMO that’s not enough. These RFCs still describe aspects of Rust that the community has discussed and found consensus on, and they still shape it. They should be kept available together with the rest of RFCs, and existing links to github’s rendering of the master branch should not be broken. |
@SimonSapin what about adding stubs like the ones I've just pushed? This will allow hosting in different places and make best use of the limited possibilities we have by pointing to Github. |
I think we'd need to talk to Mozilla's legal. I'd hope that something like what @nagisa proposes with an explicit statement that certain people possess rights to particular files would be possible. I am against removing merged RFCs from the repository, even if they remain in git history. RFCs are intended to be "permanent" so to speak... |
Removing accepted RFCs is not OK, especially after this little time. A relicensing process is hard, and we shouldn't skip steps. First of all, for the people who simply haven't responded, we should both try other contact methods and give more time. And for the people who are "unable" to give approval, we should work with them to figure out the issue there. We've gone years with the RFC repository not having a clear license; we can go a few more months while we do this the right way. |
@joshtriplett we can chat about this in private. Are you using IRC? |
Talking to @joshtriplett has convinced me to give this more time and more contact attempts before issuing further steps. |
Thanks for your work on this, @est31; please let us know if you need further help. |
A while back, my RFC to relicense this repo under a dual Apache2/MIT license has been merged. Since then I've opened five issues to track approval of the new licensing terms by the various contributors to this repository and gotten the approval of almost every contributor! Only for the contributions of 7 people I was unable to obtain approval, either because they didn't respond to my contact attempts, or because they were unable to give me approval.
The relevant commits without approval are:
These commits have touched the following files:
Additionally, Clark Gaebel has touched
active/0000-smaller-refcounts.md
, but it was moved to a rejected directory in commit 7443c30 and removed from the repository in commit abd6134.This PR removes the current incarnations of those files, ordered by contributor, except of
text/0114-closures.md
which only received typo fixes by the relevant commit. Here I've chosen a git revert instead.If in the future approval can be obtained from these contributors, I hope that their changes can be applied again.