Update RFC 2141 #2301
Update RFC 2141 #2301
Conversation
Centril
added
T-cargo
|
@sfackler want to incorporate changes for another bugfix as well? rust-lang/crates.io#1168 |
There was a problem hiding this comment.
Discussions in rust-lang/cargo#4880 need to be resolved and the resolution reflected here before this can be merged.
text/2141-alternative-registries.md
Outdated
| registry; the registry format is specified in the [Registry Index Format Specification | ||
| section][registry-index-format-specification]. | ||
| Every registry has a name, specified in the `config.json` file in its index. The name specified | ||
| must match the registry's configured name. The URL specified should contain the location of the |
There was a problem hiding this comment.
Requiring every registry to have a unique name will cause problems as outlined by alex in this comment:
Now one thing I don't like about custom names though is that it's possible to have two disjoint communities that both name their registry foo. This in turn can cause confusion and is a symptom of the fact that there's no one arbitrarting handing out names of registries.
|
@sfackler just to confirm, but if we end up going with rust-lang/cargo#4957 would you still want to switch to using names everywhere like in this RFC? |
|
Yep - the objective here is to sync the RFC up with the implementation, not to push in one direction or another. |
|
@sfackler oh but today I think the RFC is currently correct, right? In that urls are stored for dependencies in the index? (I don't think Cargo currently parses the |
|
There are some other fixes in here. I'll update to just include those. |
|
Updated |
sfackler
force-pushed
the
alt-registries-tweaks
branch
from
4c6d512
to
203c644
Compare
|
👍 |
This fixes a couple of typos and updates things to match the current implementation.
See rust-lang/cargo#4836 and rust-lang/cargo#4880.
cc @withoutboats @carols10cents @alexcrichton