Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

introduce "compiler-team contributors" #2689

Merged
merged 5 commits into from May 5, 2019

Conversation

Projects
None yet
7 participants
@nikomatsakis
Copy link
Contributor

commented Apr 18, 2019

Introduce an intermediate level of member for the compiler team, the compiler team contributor.

This proposal is part of a larger effort to introduce more structure into the compiler team's makeup. This structure should make it easier to become a part of the compiler team, by laying out a clear path to membership and by offering more official roles.

This RFC was collaboratively drafted on the compiler-team repository.

Rendered text.

To do items

@nikomatsakis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

cc @rust-lang/compiler -- this RFC tries to formalize what r+ means and also a bunch of our other implicit procedure. For those of you who didn't look at it already, please give it a read!

Note -- I am inclined to move quickly towards (at minimum) formalizing this team in the rust-lang/team repository and adding our first set of nominees (which I previously been discussed on our mailing list). I think we could do this even if we want to discuss some of the particulars that I wrote here for longer, though I suspect we may also be able to move quickly to FCP.

@nikomatsakis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 18, 2019

Ah, shoot, I forgot something that I meant to do (so I've added it to a "to do" list in the top issue). I meant to add a mention of the GH team structure. I imagine that we will want to have

  • rust-lang/compiler -- includes contributors and members, and is generally what you want
    • rust-lang/compiler-members -- includes only full members

Bikeshedding on names welcome.

Update text/0000-compiler-team-contributors.md
Co-Authored-By: nikomatsakis <niko@alum.mit.edu>
Show resolved Hide resolved text/0000-compiler-team-contributors.md Outdated

oli-obk and others added some commits Apr 22, 2019

Update text/0000-compiler-team-contributors.md
Co-Authored-By: nikomatsakis <niko@alum.mit.edu>
@nikomatsakis

This comment has been minimized.

Copy link
Contributor Author

commented Apr 23, 2019

@rfcbot fcp merge

I didn't anticipate a lot of controversy with this proposal, and indeed my expectations seem to be met. I propose that we merge this RFC.

@rfcbot

This comment has been minimized.

Copy link

commented Apr 23, 2019

Team member @nikomatsakis has proposed to merge this. The next step is review by the rest of the tagged team members:

No concerns currently listed.

Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up!

See this document for info about what commands tagged team members can give me.

@varkor

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@rfcbot reviewed

@estebank

This comment has been minimized.

Copy link
Contributor

commented Apr 23, 2019

@rfcbot review

@Centril

This comment has been minimized.

Copy link
Member

commented Apr 23, 2019

@varkor rfcbot does not listen to edits made in comments; you need to reissue the command.

@oli-obk

This comment has been minimized.

Copy link
Contributor

commented Apr 24, 2019

@rfcbot reviewed

@rfcbot

This comment has been minimized.

Copy link

commented Apr 24, 2019

🔔 This is now entering its final comment period, as per the review above. 🔔

@rfcbot

This comment has been minimized.

Copy link

commented May 4, 2019

The final comment period, with a disposition to merge, as per the review above, is now complete.

As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed.

The RFC will be merged soon.

@Centril Centril merged commit 8356d5c into rust-lang:master May 5, 2019

@Centril

This comment has been minimized.

Copy link
Member

commented May 5, 2019

Huzzah! This RFC has been merged!

Tracking issue: N/A

@Centril Centril added the A-governance label May 5, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.