Pass target directory as flag instead of env variable

rust-lang · Oct 6, 2023 · 09421fd · 09421fd
1 parent b8eae19
commit 09421fd
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/crates/flycheck/src/lib.rs b/crates/flycheck/src/lib.rs
@@ -360,10 +360,6 @@ impl FlycheckActor {
                 let mut cmd = Command::new(command);
                 cmd.envs(extra_env);
 
-                if let Some(target_dir) = target_dir {
-                    cmd.env("CARGO_TARGET_DIR", target_dir);
-                }
-
                 match invocation_location {
                     InvocationLocation::Workspace => {
                         match invocation_strategy {
@@ -381,6 +377,10 @@ impl FlycheckActor {
                     }
                 }
 
+                if let Some(target_dir) = target_dir {
+                    cmd.arg("--target-dir").arg(target_dir);
+                }
+
                 (cmd, args)
             }
         };