Highlight type aliases and attributes by default

[SomeoneToIgnore]

With zero additional highlighting-related settings and a standard VSCode dark theme, the code looks like this:

RA does not highlight unresolved entities, such as TreeRoot from the screenshot.

It also does not highlight type aliases (SyntaxNodeRef, RefRoot, OwnedRoot, GreenBuilder) and annotations (#derive) which makes it confusing and does not fit into the general scheme.

[matklad]

I think this actually regressed with the recent insiders build. We do set semantic tokens for attrs:

Specifically, I think they might have changed the name of the filed in package.json we use map sem tokens to tm scopes.

[kjeremy]

The range provider was pushed to vscode a few days ago and it looks like there' some fallout from that and a few other things.

[matklad]

fixed by #3827

Relevant docs are https://github.com/microsoft/vscode/wiki/Semantic-Highlighting-Overview

[SomeoneToIgnore]

I've installed rust-analyzer version: unreleased (09b8ee3) but see no changes.

But thanks for the PR and the docs nontheless, if you won't be able to fix it, I'll check it out some time later.

[Veetaha]

The theme you are using doesn't define any coloring for meta.attribute Textmate scope. This is quite tricky because there are loads of scopes in the wild and themes cannot support them all.

To solve this we should actually define what the default theme is and use only the scopes that it supports.

[Veetaha]

I suppose Dark+ (default dark) is what vscode uses by default. Here is its textmate grammar declration file, which extends Dark (Visual Studio) and which in turn extends Dark Default Colors

[matklad]

I must say I generally observe weirdness around syntax highlighting... microsoft/vscode#94367 is one specific issue I've tracked down, but there are more, like variables becoming bold in typescript with pale fire for some reason...

[SomeoneToIgnore]

Closing this since type aliases are now highlighted in the default theme and for the attributes there's a separate issue.