Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make 'cargo test' work #51

Closed
SimonSapin opened this issue Sep 1, 2016 · 3 comments
Closed

Make 'cargo test' work #51

SimonSapin opened this issue Sep 1, 2016 · 3 comments

Comments

@SimonSapin
Copy link
Contributor

At least some of the reason is that 9f78ea9 did not update test expectations.

Once this is fixed, cargo test should be added to .travis.yml.

@emilio
Copy link
Contributor

emilio commented Sep 1, 2016

cargo test is not expected to work, nor be up to date. It was a churn to add new tests and modify expectations, so I added the make test command.

Agreed that should be better to use a rust harness though.

@SimonSapin
Copy link
Contributor Author

Then maybe remove the tests that are not expected to pass? They’ll be in the git history when it’s time to bring them back.

@fitzgen
Copy link
Member

fitzgen commented Oct 17, 2016

I think we need a better story than we currently have for running tests, if only for potential contributors and newcomers to this code base.

Right now, I run make test and get no message about whether the test suite overall passed or had failures. I can't even rely on $?. If I look into .travis.yml, I'll find that finding out if my test run passed effectively relies on git diff'ing the test/expectations directory. But I can't even do make test on master without getting diffs in that directory!

This is not friendly for contributors. We need a much better story here.

@fitzgen fitzgen changed the title 'cargo test' fails Make 'cargo test' work Oct 17, 2016
fitzgen added a commit to fitzgen/rust-bindgen that referenced this issue Oct 17, 2016
fitzgen added a commit to fitzgen/rust-bindgen that referenced this issue Oct 18, 2016
fitzgen added a commit to fitzgen/rust-bindgen that referenced this issue Oct 18, 2016
fitzgen added a commit to fitzgen/rust-bindgen that referenced this issue Oct 18, 2016
bors-servo pushed a commit that referenced this issue Oct 18, 2016
Make `cargo test` work

Fixes #51.

r? @emilio
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants