Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add an option to add lines per module. #1308

Merged
merged 4 commits into from
May 3, 2018
Merged

Add an option to add lines per module. #1308

merged 4 commits into from
May 3, 2018

Conversation

emilio
Copy link
Contributor

@emilio emilio commented May 3, 2018

Fixes #1307

@emilio
Copy link
Contributor Author

emilio commented May 3, 2018

cc @ajeffrey

r? @fitzgen

@emilio emilio requested a review from fitzgen May 3, 2018 02:53
@emilio
Copy link
Contributor Author

emilio commented May 3, 2018

Err, meant to cc @asajeffrey

@asajeffrey
Copy link

Thanks! Here it is in action... asajeffrey/mozjs@4516ab9

fitzgen
fitzgen approved these changes May 3, 2018
View reviewed changes
Copy link
Member

@fitzgen fitzgen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Would be helpful if we had a CLI flag for this too, although I am a little unsure on what its design would be.

@fitzgen
Copy link
Member

fitzgen commented May 3, 2018

@bors-servo r+

@bors-servo
Copy link

📌 Commit 786ed31 has been approved by fitzgen

@bors-servo
Copy link

⌛ Testing commit 786ed31 with merge 9b8ddae...

bors-servo pushed a commit that referenced this pull request May 3, 2018
Auto merge of #1308 - emilio:per-module-lines, r=fitzgen
9b8ddae 
Add an option to add lines per module.

Fixes #1307
@bors-servo
Copy link

☀️ Test successful - status-travis
Approved by: fitzgen
Pushing 9b8ddae to master...

@bors-servo bors-servo merged commit 786ed31 into rust-lang:master May 3, 2018
@emilio emilio deleted the per-module-lines branch June 17, 2018 01:28
@emilio emilio mentioned this pull request Jun 17, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fitzgen fitzgen fitzgen approved these changes

Assignees

@fitzgen fitzgen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@emilio @asajeffrey @fitzgen @bors-servo @highfive