Add support for wasm_import_module #1691
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
26 tasks
emilio
approved these changes
Dec 10, 2019
|
Also, could you squash your commits? |
|
Just squashed and re-indented. |
emilio
approved these changes
Dec 11, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some of our wasm code we wanted to communicate with existing C bindings (and piggyback existing bindgen code), we needed this attribute supported from bindgen to make that work.
Without the attribute the linked code would end up in the default
envnamespace but for our use-case we needed to have these bindgen'd APIs in a different namespace.I hope I've exposed the setting in the right way but feel free to let me know otherwise.