Drop support for clang <5.0 #2166
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should have been added in rust-lang#2155 but was missed then.
Now that we require Clang 5.0, there is no way for this function to return None.
|
If and when this PR merges, there will be no more instances of |
This was referenced Feb 20, 2022
|
☔ The latest upstream changes (presumably 6a169f2) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the vein of #1807, the current PR removes
bindgen's support for Clang 4.0. After this PR, the minimum Clang version supported is 5.0.1, which was released on 21 Dec 2017.This PR follows on from #2155, which removed support for versions prior to Clang 4.0. The current PR also cleans up some things that should have been caught when support for Clang <4.0 was removed.