Use clang_getFileLocation instead of clang_getSpellingLocation #2824
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both had the same behavior... until llvm/llvm-project@2e770ed which fixed getSpellingLocation, but bindgen looks like it actually expects the getFileLocation result.
emilio
approved these changes
Apr 29, 2024
moz-v2v-gh
pushed a commit
to mozilla/gecko-dev
that referenced
this pull request
May 2, 2024
…r=emilio,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D209112
ErichDonGubler
pushed a commit
to erichdongubler-mozilla/firefox
that referenced
this pull request
May 2, 2024
…r=emilio,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D209112
i3roly
pushed a commit
to i3roly/firefox-dynasty
that referenced
this pull request
Jun 1, 2024
…r=emilio,supply-chain-reviewers Differential Revision: https://phabricator.services.mozilla.com/D209112
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both had the same behavior... until llvm/llvm-project@2e770ed which fixed getSpellingLocation, but bindgen looks like it actually expects the getFileLocation result.